Chronological Thread 

< Chronological >      < Thread >

---

Hi!

Last time I met with Anna and she went over the pull request we made
together (for the admin page), trying to understand it and comment. I
think this is a great way to learn more about PeerLibrary codebase. So I
would really encourage everybody, especially people who have not yet
contributed, or feel that they lack understanding of the codebase, to go
over pull requests we made until now (open or closed) and read them a
bit and try to understand them (pull requests are more or less one unit
so it is easier to understand them than everything). Feel free to make
any comments or questions (GitHub allows inline comments on the code),
even if just about how something works (this probably means our code is
not commented well). So use pull requests to learn! (And maybe even make
a new pull request with improved code comments.)

This is also important because our contribution process is that we are
using pull requests and once author(s) of the pull requests are
satisfied with the pull request, others should do a code review and give
them feedback. After few iterations, once there is an agreement that
pull request is good, author(s) merge them in.

And currently Rodrigo and I are the only one doing code reviews to each
other and confirming that pull requests are good to go in. This makes me
sad. But, you can help! :-) Learn and give feedback. Peer learning is
the best way of learning. We all learn from each other.

https://github.com/peerlibrary/peerlibrary/wiki/Development-Model


Mitar

--
http://mitar.tnode.com/
https://twitter.com/mitar_m

---

• [PeerLibrary dev] Pull requests and commenting, Mitar, 12/18/2013

---

Archive powered by MHonArc 2.6.18.